Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initialSetup with allowFirstVideo #4897

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Aug 14, 2024

Task/Issue URL: https://app.asana.com/0/1201141132935289/1208043449791997/f

Description

Steps to test this PR

Feature 1

  • Open a video in Duck Player with settings to Always Ask
  • Click the watch in YouTube Button
  • Check overlay isn't shown

Copy link
Contributor Author

CrisBarreiro commented Aug 14, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch 2 times, most recently from 4229f6f to c612fce Compare August 14, 2024 09:54
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch from c612fce to a5175df Compare August 20, 2024 10:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player-contingency-settings branch from bc703cd to 4f62fef Compare August 20, 2024 11:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch from a5175df to cc594ee Compare August 20, 2024 11:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player-contingency-settings branch from 4f62fef to bf706ab Compare August 20, 2024 11:14
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch from cc594ee to a49ff12 Compare August 20, 2024 11:14
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player-contingency-settings branch from bf706ab to 2680c38 Compare August 20, 2024 15:28
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch from a49ff12 to f270933 Compare August 20, 2024 15:28
Base automatically changed from feature/cris/duck-player-contingency-settings to feature/cris/duckplayer/create-module August 20, 2024 15:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from 2680c38 to 909e2a0 Compare August 21, 2024 09:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch from f270933 to dd3df3a Compare August 21, 2024 09:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from 909e2a0 to 6f07120 Compare August 21, 2024 10:45
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/allow-first-video branch from dd3df3a to 3e646bc Compare August 21, 2024 10:45
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from 6f07120 to a1ed27b Compare August 21, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants