Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RMF matchers for duckPlayerOnboarded and duckPlayerEnabled #4917

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Aug 19, 2024

Task/Issue URL: https://app.asana.com/0/1205008441501016/1208088492211812/f

Description

Steps to test this PR

Pre-requisites

  1. Checkout content-scope-scripts branch pr-releases/pr-993
  2. Set PRIVACY_REMOTE_CONFIG_URL to https://www.jsonblob.com/api/1252645298605252608
  3. Set RemoteMessagingService#config() URL to https://jsonblob.com/api/1275101402324918272

Test steps

  • Fresh install the app. Do the onboarding steps. Do steps 2 and 3 from above.
  • Run the app, check if you see the "A message for users not onboarded to Duck Player" message. Dismiss it
  • Open Youtube.com. Search for Iron Maiden. Tap on "Watch in Duck Player"
  • Close the tab, kill the app.
  • Change the version here from 1 to 2
  • Open the app, check if you see the A message for Duck Player onboarded users. Dismiss it
  • Go to settings, Duck Player, change "Open Videos in Duck Player" to "Always"
  • Kill the app
  • Change the version here from 2 to 3
  • Open the app, check if you see the A message for Duck Player enabled users

UI changes

image
image
image

Copy link
Contributor Author

CrisBarreiro commented Aug 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from dc3c086 to 9e9d625 Compare August 19, 2024 18:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from a795252 to e691d88 Compare August 19, 2024 18:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from 9e9d625 to 44ee890 Compare August 19, 2024 18:18
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from e691d88 to 4117461 Compare August 19, 2024 18:18
@CrisBarreiro CrisBarreiro mentioned this pull request Aug 19, 2024
1 task
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from 44ee890 to d2f5b62 Compare August 20, 2024 10:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from 4117461 to 9ef7562 Compare August 20, 2024 10:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from d2f5b62 to 8ab4c9a Compare August 20, 2024 10:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from 9ef7562 to 00a6455 Compare August 20, 2024 10:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from 8ab4c9a to 7103e11 Compare August 20, 2024 11:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from 00a6455 to 8cb883b Compare August 20, 2024 11:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from 7103e11 to a098918 Compare August 20, 2024 11:14
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from 8cb883b to 14134e9 Compare August 20, 2024 11:14
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from a098918 to 716649f Compare August 20, 2024 15:28
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from 14134e9 to b98cb8f Compare August 20, 2024 15:28
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from 716649f to 8e5af21 Compare August 21, 2024 09:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/rmf-matchers branch from b98cb8f to bec3036 Compare August 21, 2024 09:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/pixels branch from 8e5af21 to d65ba65 Compare August 21, 2024 10:45
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants