Add pixels

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/0/0/1208011850423576/f

Description

Steps to test this PR https://app.asana.com/0/72649045549333/1207551634140422/f

[CrisBarreiro]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Create RMF matchers for duckPlayerOnboarded and duckPlayerEnabled #4917
• Add pixels #4902 👈
• Update initialSetup with allowFirstVideo #4897
• Add support for Duck Player #4663 : 12 other dependent PRs (#4748 , #4752 , #4780 and 9 others)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite

[marcosholgado]

LGTM. I'd like to find a way to move most of the logic from the DuckPlayerJsHelper into the duck player module but that's ok for now.

Also I'm not sure if this is the expected behaviour so just noting it here for you to check. The duck-player_view-from_other pixel is fired after clicking turn on duck player on the overlay, I don't think it should be fired though but not 100% sure.

[CrisBarreiro]

LGTM. I'd like to find a way to move most of the logic from the DuckPlayerJsHelper into the duck player module but that's ok for now.

Also I'm not sure if this is the expected behaviour so just noting it here for you to check. The duck-player_view-from_other pixel is fired after clicking turn on duck player on the overlay, I don't think it should be fired though but not 100% sure.

@marcosholgado you're right. That pixel shouldn't be fired

on #1. There are a couple of reasons why I decided to keep it on the app module

• I think the fact we're using JS messages is an implementation detail on the browser, not Duck Player itsels
• We can't access BrowserTabViewModelcommands from Duck Player. However, we could introduce some "commands" in Duck Player and then map them to the actual ones in BrowserTabViewModel

No strong opinions though

[marcosholgado]

LGTM. I'd like to find a way to move most of the logic from the DuckPlayerJsHelper into the duck player module but that's ok for now.
Also I'm not sure if this is the expected behaviour so just noting it here for you to check. The duck-player_view-from_other pixel is fired after clicking turn on duck player on the overlay, I don't think it should be fired though but not 100% sure.

@marcosholgado you're right. That pixel shouldn't be fired

on #1. There are a couple of reasons why I decided to keep it on the app module

• I think the fact we're using JS messages is an implementation detail on the browser, not Duck Player itsels
• We can't access BrowserTabViewModelcommands from Duck Player. However, we could introduce some "commands" in Duck Player and then map them to the actual ones in BrowserTabViewModel

No strong opinions though

Fair

[CrisBarreiro]

@marcosholgado the pixel was fired due to a regression in CSS. There's a new commit addressing it on the CSS branch