Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of returning prepared tx from mint client #334

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Example of returning prepared tx from mint client #334

merged 3 commits into from
Nov 8, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 8, 2023 •
edited by iainnash
Loading

Generated summary (powered by Graphite)

TL;DR

This pull request makes changes to the mint-client.test.ts and mint-client.ts files. It introduces a new method makePrepareMintTokenParams in the MintClient class, modifies the existing mintToken method, and updates the mintZora1155 and mintZora721 private methods. The changes allow for the simulation of contract parameters before writing to the contract.

What changed

  • Added a new method makePrepareMintTokenParams in the MintClient class.
  • Modified the existing mintToken method in the MintClient class.
  • Updated the mintZora1155 and mintZora721 private methods in the MintClient class.

How to test

  1. Run the test suite for mint-client.test.ts.
  2. Verify that the simulation of contract parameters is working as expected.
  3. Test the makePrepareMintTokenParams method with different inputs and verify the results.
  4. Test the modified mintToken method with different inputs and verify the results.
  5. Test the updated mintZora1155 and mintZora721 private methods with different inputs and verify the results.

Why make this change

This change allows for the simulation of contract parameters before writing to the contract. This can help in identifying any potential issues or errors before executing the actual contract transaction. It improves the reliability and safety of the minting process.

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 8, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@oveddan oveddan mentioned this pull request Nov 8, 2023
Merged
@oveddan oveddan mentioned this pull request Nov 8, 2023
Merged
@iainnash iainnash merged commit 5e4b6fa into rename_protocol_sdk Nov 8, 2023
4 of 5 checks passed
@iainnash iainnash deleted the return-prepared-tx branch November 8, 2023 19:24
This was referenced Nov 8, 2023
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Merged
This was referenced Nov 14, 2023
Merged
Closed
oveddan added a commit that referenced this pull request Apr 8, 2024
@oveddan
cleanup changesets (#334)
7aff93d 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## Does this change the ABI/API?

- [ ] This changes the ABI/API

<!-- If so, please describe how and what potential impact this may have -->

## What tests did you add/modify to account for these changes

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New module / feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] i added a changeset to account for this change

## Reviewer Checklist:

- [ ] My review includes a symposis of the changes and potential issues
- [ ] The code style is enforced
- [ ] There are no risky / concerning changes / additions to the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainnash iainnash iainnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oveddan @iainnash