Move deployment related config to protocol-deployments #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Nov 9, 2023
Merged
oveddan
force-pushed
the
move-deployment-utils-to-protocol-deployments
branch
from
526aee9
to
5d86660
Compare
Closed
oveddan
force-pushed
the
move-deployment-utils-to-protocol-deployments
branch
from
5d86660
to
0a49450
Compare
oveddan
changed the base branch from
main
to
remove-supply-royalty-deprecation-test
oveddan
force-pushed
the
move-deployment-utils-to-protocol-deployments
branch
from
0a49450
to
a50ae1c
Compare
This was referenced Nov 13, 2023
Merged
This was referenced Nov 13, 2023
oveddan
changed the base branch from
remove-supply-royalty-deprecation-test
to
main
oveddan
force-pushed
the
move-deployment-utils-to-protocol-deployments
branch
from
c5b24e9
to
766037e
Compare
oveddan
force-pushed
the
move-deployment-utils-to-protocol-deployments
branch
from
766037e
to
c29433e
Compare
kulkarohan
approved these changes
Nov 14, 2023
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155. This moves all Deployment related code to the `protocol-deployments` package, thus removing that link. See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155. This moves all Deployment related code to the `protocol-deployments` package, thus removing that link. See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155. This moves all Deployment related code to the `protocol-deployments` package, thus removing that link. See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
oveddan
added a commit
that referenced
this pull request
Apr 9, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description This updates the changelog to show how rewards splits were changed to be calculated based on % ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## Does this change the ABI/API? - [ ] This changes the ABI/API <!-- If so, please describe how and what potential impact this may have --> ## What tests did you add/modify to account for these changes <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New module / feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] i added a changeset to account for this change ## Reviewer Checklist: - [ ] My review includes a symposis of the changes and potential issues - [ ] The code style is enforced - [ ] There are no risky / concerning changes / additions to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the
testfolder, and we get an error its looking for fixtures in thetestfolder of 1155. This moves all Deployment related code to theprotocol-deploymentspackage, thus removing that link.See this in action in the downstream PR #340 where we can pin
protocol-deploymentsto a specific version of1155-contracts- 2.4.0