-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fork rpc and block number to be specified in anvil tests #362
Merged
oveddan
merged 1 commit into
main
from
11-14-Allow_fork_rpc_and_block_number_to_be_specified
Nov 15, 2023
Merged
Allow fork rpc and block number to be specified in anvil tests #362
oveddan
merged 1 commit into
main
from
11-14-Allow_fork_rpc_and_block_number_to_be_specified
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2023
Merged
Closed
This was referenced Nov 14, 2023
Merged
Merged
iainnash
previously approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nice to know you can add args in there.
Will this break current tests or require sensible defaults?
oveddan
changed the base branch from
move-deployment-utils-to-protocol-deployments
to
main
November 14, 2023 23:24
oveddan
force-pushed
the
11-14-Allow_fork_rpc_and_block_number_to_be_specified
branch
from
November 14, 2023 23:24
f910167
to
faeff94
Compare
the default is still called |
oveddan
force-pushed
the
11-14-Allow_fork_rpc_and_block_number_to_be_specified
branch
from
November 15, 2023 00:45
faeff94
to
8e5aed9
Compare
This was referenced Nov 15, 2023
Closed
oveddan
force-pushed
the
formatted-prettier
branch
from
November 15, 2023 01:10
164e5a1
to
140e699
Compare
oveddan
force-pushed
the
11-14-Allow_fork_rpc_and_block_number_to_be_specified
branch
from
November 15, 2023 01:10
8e5aed9
to
06db23c
Compare
oveddan
force-pushed
the
11-14-Allow_fork_rpc_and_block_number_to_be_specified
branch
from
November 15, 2023 01:12
06db23c
to
cf76fd5
Compare
This was referenced Nov 17, 2023
Merged
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
Allowing fork rpc url and block number to be specified in fork tests
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Allowing fork rpc url and block number to be specified in fork tests
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Allowing fork rpc url and block number to be specified in fork tests
iainnash
deleted the
11-14-Allow_fork_rpc_and_block_number_to_be_specified
branch
January 11, 2024 15:36
oveddan
added a commit
that referenced
this pull request
Jun 4, 2024
…155 factory (#362) * Save versions and missing upgrade paths. For test, add upgrade path registration. * more versions * only filter versions to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing fork rpc url and block number to be specified in fork tests