Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fork rpc and block number to be specified in anvil tests #362

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 14, 2023

Allowing fork rpc url and block number to be specified in fork tests

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 14, 2023

iainnash
iainnash previously approved these changes Nov 14, 2023
Copy link
Collaborator

@iainnash iainnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice to know you can add args in there.

Will this break current tests or require sensible defaults?

@oveddan oveddan changed the base branch from move-deployment-utils-to-protocol-deployments to main November 14, 2023 23:24
@oveddan oveddan dismissed iainnash’s stale review November 14, 2023 23:24

The base branch was changed.

@oveddan oveddan force-pushed the 11-14-Allow_fork_rpc_and_block_number_to_be_specified branch from f910167 to faeff94 Compare November 14, 2023 23:24
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 14, 2023

the default is still called anvilTest this just adds the ability to create an override with makeAnvilTest

@oveddan oveddan changed the base branch from main to formatted-prettier November 15, 2023 00:45
@oveddan oveddan force-pushed the 11-14-Allow_fork_rpc_and_block_number_to_be_specified branch from faeff94 to 8e5aed9 Compare November 15, 2023 00:45
@oveddan oveddan force-pushed the 11-14-Allow_fork_rpc_and_block_number_to_be_specified branch from 8e5aed9 to 06db23c Compare November 15, 2023 01:10
@oveddan oveddan changed the base branch from formatted-prettier to main November 15, 2023 01:12
@oveddan oveddan force-pushed the 11-14-Allow_fork_rpc_and_block_number_to_be_specified branch from 06db23c to cf76fd5 Compare November 15, 2023 01:12
@oveddan oveddan merged commit 957aa2f into main Nov 15, 2023
7 checks passed
iainnash pushed a commit that referenced this pull request Jan 5, 2024
Allowing fork rpc url and block number to be specified in fork tests
iainnash pushed a commit that referenced this pull request Jan 11, 2024
Allowing fork rpc url and block number to be specified in fork tests
iainnash pushed a commit that referenced this pull request Jan 11, 2024
Allowing fork rpc url and block number to be specified in fork tests
@iainnash iainnash deleted the 11-14-Allow_fork_rpc_and_block_number_to_be_specified branch January 11, 2024 15:36
oveddan added a commit that referenced this pull request Jun 4, 2024
…155 factory (#362)

* Save versions and missing upgrade paths.
For test, add upgrade path registration.

* more versions

* only filter versions to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants