Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy 2.4.0 #340

Closed
wants to merge 1 commit into from
Closed

Deploy 2.4.0 #340

wants to merge 1 commit into from

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 9, 2023

No description provided.

This was referenced Nov 9, 2023
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 9, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 9, 2023
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
@oveddan oveddan changed the base branch from move-deployment-utils-to-protocol-deployments to remove-supply-royalty-deprecation-test November 9, 2023 23:36
@oveddan oveddan mentioned this pull request Nov 9, 2023
Merged
@oveddan oveddan force-pushed the remove-supply-royalty-deprecation-test branch from 4dce800 to edcd9cc Compare November 10, 2023 00:14
@oveddan oveddan mentioned this pull request Nov 10, 2023
Merged
@oveddan oveddan force-pushed the remove-supply-royalty-deprecation-test branch from edcd9cc to 14683d5 Compare November 10, 2023 01:30
@oveddan oveddan changed the base branch from remove-supply-royalty-deprecation-test to move-deployment-utils-to-protocol-deployments November 10, 2023 01:30
@oveddan oveddan force-pushed the deploy-2.4.0-prerelease branch 2 times, most recently from 6c59ba3 to 2778576 Compare November 10, 2023 01:41
This was referenced Nov 13, 2023
Merged
Merged
This was referenced Nov 13, 2023
Closed
Merged
Merged
Merged
@oveddan oveddan force-pushed the move-deployment-utils-to-protocol-deployments branch 2 times, most recently from 766037e to c29433e Compare November 14, 2023 20:06
@oveddan oveddan mentioned this pull request Nov 14, 2023
Merged
oveddan added a commit that referenced this pull request Nov 14, 2023
@oveddan
Move deployment related config to protocol-deployments (#339)
293e2c0 
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155.  This moves all Deployment related code to the `protocol-deployments` package, thus removing that link.

See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
@oveddan oveddan changed the base branch from move-deployment-utils-to-protocol-deployments to main November 14, 2023 23:59
@oveddan oveddan force-pushed the deploy-2.4.0-prerelease branch 2 times, most recently from 5612798 to e907c9b Compare November 15, 2023 23:01
@oveddan oveddan mentioned this pull request Nov 15, 2023
Closed
@oveddan oveddan changed the title Deploy 2.4.0 to zora-testnet (prerelease) Deploy 2.4.0 (prerelease) Nov 16, 2023
@oveddan oveddan force-pushed the deploy-2.4.0-prerelease branch 3 times, most recently from d2fb1d2 to 554aa1c Compare November 17, 2023 16:29
@oveddan oveddan changed the title Deploy 2.4.0 (prerelease) Deploy 2.4.0 Nov 17, 2023
@oveddan oveddan closed this Nov 17, 2023
@oveddan oveddan deleted the deploy-2.4.0-prerelease branch November 17, 2023 20:24
iainnash pushed a commit that referenced this pull request Jan 5, 2024
@oveddan @kulkarohan
Move deployment related config to protocol-deployments (#339)
72b0a44 
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155.  This moves all Deployment related code to the `protocol-deployments` package, thus removing that link.

See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
iainnash pushed a commit that referenced this pull request Jan 11, 2024
@oveddan
Move deployment related config to protocol-deployments (#339)
a06a404 
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155.  This moves all Deployment related code to the `protocol-deployments` package, thus removing that link.

See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
iainnash pushed a commit that referenced this pull request Jan 11, 2024
@oveddan @kulkarohan
Move deployment related config to protocol-deployments (#339)
7a76cc9 
If we choose to pin protocol-deployments to a specific version of 1155, it imports it via npm and doesnt symlink, thus losing the `test` folder, and we get an error its looking for fixtures in the `test` folder of 1155.  This moves all Deployment related code to the `protocol-deployments` package, thus removing that link.

See this in action in the downstream PR #340 where we can pin `protocol-deployments` to a specific version of `1155-contracts` - 2.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oveddan