commands: add `rbfpsbt` command #816

jp1ac4 · 2023-11-16T16:39:34Z

This PR relates to #43 and #236.

It adds a rbfpsbt command that generates a PSBT to replace an existing transaction using RBF. This replacement can either preserve non-change outputs and simply bump fees or remove non-change outputs and effectively cancel the transaction. The inputs and change output may need to be updated in accordance with the higher fee.

I've also added a getmempoolentry call to the bitcoin interface that is used for checking information about descendant transactions.

To facilitate development, I've made some temporary changes in the GUI so that replacement PSBTs can be signed and broadcast, but these changes might not be part of this PR in the end.

src/bitcoin/d/mod.rs

src/commands/mod.rs

src/bitcoin/d/mod.rs

jp1ac4 · 2023-11-17T16:10:37Z

src/commands/mod.rs

+        // sum of fees paid by original transactions + incremental feerate * replacement size.
+        for i in 0..100_u64 {
+            println!("trying feerate of {} with i {}", feerate_vb + i, i);
+            let rbf_psbt = self.create_rbf_spend(


In case change_index is None, I can pass an arbitrary value here to avoid incrementing the change index while we try different feerates, and then once the necessary feerate has been found, we can do a final call that increments the change index if necessary.

Instead of this initial idea, I instead pass the next change address directly to create_spend_internal. It might be that we still increment the change index once in an intermediate call and then the final transaction won't have change, but this approach seems simpler.

darosior

I'm a bit baffled by your iterating approach to get the minimum absolute fee.

src/commands/mod.rs

darosior · 2023-11-20T11:47:28Z

src/commands/mod.rs

+                .ok_or(CommandError::InsaneFees(InsaneFeeInfo::InvalidFeerate))?
+        };
+        // Check replacement transaction's feerate is greater than previous feerate (the only directly conflicting transaction).
+        // TODO: Should we throw error or just set feerate_vb = prev_feerate_vb + 1 and check `rbf_psbt` below?


I think:

We should let them provide a feerate for fee bumps. In this case, we should explicitly error if they set a too low feerate.

We should not require a feerate for cancels. In this case we should set the feerate to the minimum necessary to both not lower the absolute fee and increment the feerate.

I've added some logic along these lines, although it might need some tweaking.

src/commands/mod.rs

jp1ac4 · 2023-11-21T13:06:54Z

I rebased on master and updated the functional test for the new rbfpsbt command, which depends on the fix from #829.

Other changes relating to the comments above are still ongoing.

darosior

Looking good!

tests/test_rpc.py

gui/src/app/state/transactions.rs

gui/src/daemon/model.rs

src/commands/mod.rs

src/commands/utils.rs

src/commands/mod.rs

jp1ac4 · 2023-11-28T14:58:37Z

src/commands/mod.rs

+            .filter_map(|c| {
+                // In case the user attempts RBF before the previous coins have been updated in the DB,
+                // they would be returned as confirmed and not spending.
+                if !prev_coins.contains_key(&c.outpoint) {


An alternative would be to wait for the spend info of all coins to be updated.

jp1ac4 · 2023-11-28T15:03:48Z

src/commands/mod.rs

+                // transaction, then set all previous coins as mandatory and add confirmed coins as
+                // optional, unless we have already done this.
+                Err(CommandError::CoinSelectionError(_))
+                    if is_cancel && candidate_coins.iter().all(|c| !c.must_select) =>


An alternative approach later on might be for coin selection to pick at least one from a subset. E.g. we could use a metric that only returns a score if the selection includes at least one candidate from this subset. So for the cancel case, we would want at least one from the previous inputs, and then zero or more from the optional.

darosior

Haven't looked at the tests yet. This is looking good, i like the create_spend_internal interface, definitely paving the way for completely abstracting out the spend creation. Nice commits organization too, although i'd have made a ~~simple~~ single commit of 5fe6ae9 and 41d6a4b so it can be reviewed using --color-moved=dimmed-zebra.

src/bitcoin/d/mod.rs

doc/API.md

src/commands/mod.rs

doc/API.md

src/commands/mod.rs

darosior · 2023-11-29T16:47:23Z

src/commands/mod.rs

        // sanity check each output's value.
-        let mut psbt_outs = Vec::with_capacity(destinations.len());
+        let mut destinations_checked: HashMap<bitcoin::Address, bitcoin::Amount> =


No need for the type declaration here

I've removed this and a similar one in rbf_psbt().

jp1ac4 · 2023-11-30T00:44:01Z

i'd have made a simple commit of 5fe6ae9 and 41d6a4b so it can be reviewed using --color-moved=dimmed-zebra.

Sure, I'll squash those two commits. I kept them separate just to keep options open as I wasn't sure what would be best.

darosior · 2023-11-30T09:57:15Z

src/commands/mod.rs

+                .iter()
+                .filter_map(|(addr, amt, _)| {
+                    if prev_change_address != Some(addr) {
+                        Some((addr.clone(), *amt))


Can use into_iter() and avoid this clone.

Probably a good idea to move prev_change_address's cloned() from below to just above if you do that.

I've now made this change.

darosior · 2023-11-30T11:10:40Z

Just realized that actually this doesn't support RBF'ing a recovery transaction as in this case we need to set the right sequence in the inputs.

darosior · 2023-11-30T11:22:17Z

I've been working on top of this branch and been running the functional tests a lot. Noticed a somewhat flaky RBF test. FYI:

s...............................F..                                                                                                                                                              [100%]                                                                                                                                                                                                                                 
=============================================================================================== FAILURES ===============================================================================================                                                                                                                                                                                                                                
_________________________________________________________________________________________ test_rbfpsbt_cancel __________________________________________________________________________________________                                                                                                                                                                                                                                
[gw9] linux -- Python 3.11.6 /home/darosior/projects/wizardsardine/liana/venv/bin/python3                                                                                                                                                                                                                                                                                                                                               
                                                                                                                                                                                                                                                                                                                                                                                                                                        
lianad = <test_framework.lianad.Lianad object at 0x7fc4a0ad71d0>, bitcoind = <test_framework.bitcoind.Bitcoind object at 0x7fc493f33090>                                                                                                                                                                                                                                                                                                
                                                                                                                                                                                                                                                                                                                                                                                                                                        
    def test_rbfpsbt_cancel(lianad, bitcoind):                                                                                                                                                                                                                                                                                                                                                                                          
        """Test the use of RBF to cancel a transaction."""                                                                                                                                                                                                                                                                                                                                                                              
                                                                                                                                                                                                                                                                                                                                                                                                                                        
        # Get three coins.                                                                                                                                                                                                                                                                                                                                                                                                              
        destinations = {                                                                                                                                                                                                                                                                                                                                                                                                                
            lianad.rpc.getnewaddress()["address"]: 0.003,                                                                                                                                                                                                                                                                                                                                                                               
            lianad.rpc.getnewaddress()["address"]: 0.004,                                                                                                                                                                                                                                                                                                                                                                               
            lianad.rpc.getnewaddress()["address"]: 0.005,                                                 
        }                                                                                                 
        txid = bitcoind.rpc.sendmany("", destinations)                                                    
        bitcoind.generate_block(1, wait_for_mempool=txid)                                                 
        wait_for(lambda: len(lianad.rpc.listcoins(["confirmed"])["coins"]) == 3)                          
        coins = lianad.rpc.listcoins(["confirmed"])["coins"]                                              
                                                                                                          
        # Create a spend that will later be replaced.                                                     
        first_outpoints = [c["outpoint"] for c in coins[:2]]                                              
        destinations = {                                                                                  
            bitcoind.rpc.getnewaddress(): 650_000,                                                        
        }                                                                                                 
        first_res = lianad.rpc.createspend(destinations, first_outpoints, 1)                              
        first_psbt = PSBT.from_base64(first_res["psbt"])                                                  
        # The transaction has a change output.                                                            
        assert len(first_psbt.o) == len(first_psbt.tx.vout) == 2                                          
        first_txid = first_psbt.tx.txid().hex()                                                           
        # Broadcast the spend and wait for it to be detected.                                             
        first_txid = sign_and_broadcast_psbt(lianad, first_psbt)                                          
        wait_for(                                                                                         
            lambda: all(                                                                                  
                c["spend_info"] is not None and c["spend_info"]["txid"] == first_txid                     
                for c in lianad.rpc.listcoins([], first_outpoints)["coins"]                               
            )                                                                                             
        )                                                                                                 
        # We can use RBF and let the command choose the min possible feerate (1 larger than previous).                                                                                                              
        rbf_1_res = lianad.rpc.rbfpsbt(first_txid, True)                                                  
        # We can also pass the feerate explicitly.                                                        
        rbf_1_res = lianad.rpc.rbfpsbt(first_txid, True, 2)                                               
        rbf_1_psbt = PSBT.from_base64(rbf_1_res["psbt"])                                                  
        # Replacement only has a single input.                                                            
        assert len(rbf_1_psbt.i) == 1                                                                     
        # This input is one of the two from the previous transaction.                                     
        assert rbf_1_psbt.i[0].map[PSBT_IN_NON_WITNESS_UTXO] in [                                         
            psbt_in.map[PSBT_IN_NON_WITNESS_UTXO] for psbt_in in rbf_1_psbt.i                             
        ]                                                                                                 
        # The replacement only has a change output.                                                       
        assert len(rbf_1_psbt.tx.vout) == 1                                                               
        # Change address is the same but change amount will be higher in the replacement as it is the only output.                                                                                                  
        assert first_psbt.tx.vout[1].nValue < rbf_1_psbt.tx.vout[0].nValue                                
        assert first_psbt.tx.vout[1].scriptPubKey == rbf_1_psbt.tx.vout[0].scriptPubKey                   
        # Broadcast the replacement and wait for it to be detected.                                       
        rbf_1_txid = sign_and_broadcast_psbt(lianad, rbf_1_psbt)                                          
        # The spend info of the coin used in the replacement will be updated.                             
                                                                                                          
        rbf_1_outpoint = (                                                                                
            f"{rbf_1_psbt.tx.vin[0].prevout.hash:x}:{rbf_1_psbt.tx.vin[0].prevout.n}"                     
        )                                                                                                 
>       assert rbf_1_outpoint in first_outpoints                                                          
E       AssertionError: assert '389e33bec707e74f00650f337f576e236eb3a088c36c6999cf148698c9ba751:1' in ['0389e33bec707e74f00650f337f576e236eb3a088c36c6999cf148698c9ba751:1', '0389e33bec707e74f00650f337f576e236eb3a088c36c6999cf148698c9ba751:3']

tests/test_rpc.py:1210: AssertionError                                                                    
---------------------------------------------------------------------------------------- Captured stdout setup -----------------------------------------------------------------------------------------            
Running tests in /tmp/lianad-tests-up_02ari                                                               
--------------------------------------------------------------------------------------- Captured stdout teardown ---------------------------------------------------------------------------------------            
Test failed, leaving directory '/tmp/lianad-tests-up_02ari/test_rbfpsbt_cancel_1' intact                  
Leaving base dir '/tmp/lianad-tests-up_02ari' as it still contains ['test_rbfpsbt_cancel_1']              
======================================================================================= short test summary info ========================================================================================            
FAILED tests/test_rpc.py::test_rbfpsbt_cancel - AssertionError: assert '389e33bec707e74f00650f337f576e236eb3a088c36c6999cf148698c9ba751:1' in ['0389e33bec707e74f00650f337f576e236eb3a088c36c6999cf148698c9ba751:1', '0389e33bec707e74f00650f337f57...
=============================================================================== 1 failed, 33 passed, 1 skipped in 35.95s ===============================================================================

jp1ac4 · 2023-12-04T20:30:50Z

Thanks for spotting the flaky test. I think the following should fix that error:

diff --git a/tests/test_rpc.py b/tests/test_rpc.py
index 6b3004b..69ecce3 100644
--- a/tests/test_rpc.py
+++ b/tests/test_rpc.py
@@ -1203,7 +1203,7 @@ def test_rbfpsbt_cancel(lianad, bitcoind):
     # The spend info of the coin used in the replacement will be updated.
 
     rbf_1_outpoint = (
-        f"{rbf_1_psbt.tx.vin[0].prevout.hash:x}:{rbf_1_psbt.tx.vin[0].prevout.n}"
+        f"{rbf_1_psbt.tx.vin[0].prevout.hash:064x}:{rbf_1_psbt.tx.vin[0].prevout.n}"
     )
     assert rbf_1_outpoint in first_outpoints

The left-hand value in your error is missing the leading zero from the right-hand side, so this change should ensure the value is padded with zeros.

jp1ac4 · 2023-12-05T04:00:53Z

Sure, I'll squash those two commits. I kept them separate just to keep options open as I wasn't sure what would be best.

I've now done this.

jp1ac4 · 2023-12-05T04:10:45Z

I've now addressed the comments.

darosior · 2023-12-05T09:51:57Z

@edouardparis can you have a quick look at 01d50c9?

jp1ac4 · 2023-12-05T20:56:52Z

src/commands/mod.rs

@@ -171,6 +173,19 @@ pub enum InsaneFeeInfo {
    TooHighFeerate(u64),
 }

+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum RbfErrorInfo {
+    TooLowFeerate(u64),


I think it would be helpful to include the min feerate here as well as / instead of the chosen feerate.

I haven't changed this yet. We could leave for a follow-up.

darosior · 2023-12-05T17:54:43Z

src/bitcoin/d/mod.rs

+        let fees_json = json
+            .get("fees")
+            .expect("Must be present in bitcoind response")
+            .clone();


nit (to avoid the clone, feel free to ignore):

diff --git a/src/bitcoin/d/mod.rs b/src/bitcoin/d/mod.rs index c993813..8c52a1b 100644 --- a/src/bitcoin/d/mod.rs +++ b/src/bitcoin/d/mod.rs @@ -1413,15 +1413,13 @@ impl From<Json> for MempoolEntry { .get("vsize") .and_then(Json::as_u64) .expect("Must be present in bitcoind response"); - let fees_json = json + let fees = json .get("fees") + .as_ref() .expect("Must be present in bitcoind response") - .clone(); + .into(); - MempoolEntry { - vsize, - fees: MempoolEntryFees::from(fees_json), - } + MempoolEntry { vsize, fees } } } @@ -1431,8 +1429,8 @@ pub struct MempoolEntryFees { pub descendant: bitcoin::Amount, } -impl From<Json> for MempoolEntryFees { - fn from(json: Json) -> MempoolEntryFees { +impl From<&&Json> for MempoolEntryFees { + fn from(json: &&Json) -> MempoolEntryFees { let json = json.as_object().expect("fees must be an object"); let base = json .get("base")

darosior · 2023-12-05T18:07:38Z

doc/API.md

+| `is_cancel` | bool              | Whether to "cancel" the transaction or simply bump the fee.     |
+| `feerate`   | integer(optional) | Target feerate for the RBF transaction (in sat/vb).             |


I'm not fond of having both as separate parameters since the feerate should always be set if it's not a cancel. But i don't have a better suggestion.

darosior · 2023-12-05T18:13:37Z

src/commands/mod.rs

+        is_cancel: bool,
+        feerate_vb: Option<u64>,
+    ) -> Result<CreateSpendResult, CommandError> {
+        // The transaction to be replaced must be one of ours and so we can assume it signals replaceability.


nit: we could have a sanity check for this since we are already iterating over the inputs of the existing PSBT anyways.

darosior · 2023-12-06T08:04:03Z

src/commands/mod.rs

+        // Get the spending transactions of the coins from DB in order to determine the transactions
+        // that are directly conflicting with the replacement transaction we will create.
+        // Note that the DB may be missing very recently broadcast transactions.
+        let mut dir_conflict_txids: HashSet<bitcoin::Txid> = prev_coins
+            .values()
+            .filter_map(|coin| coin.spend_txid)
+            .collect();


I don't think we should be silently ignoring those we haven't yet marked as spent. Or we might create a PSBT which the user would go through the hassle of signing (and potentially getting signed by others) just for it to not be broadcastable in the end. I know i'm walking back from #816 (comment) but giving it more thought i don't think it's reasonable. I can also tackle this in a follow-up.

darosior · 2023-12-06T08:12:33Z

src/commands/mod.rs

+        // In case this transaction is not in the mempool, we assume that it is finalized when
+        // calculating its fee and vsize below, i.e. we assume that this RBF command is used only
+        // on finalized PSBTs.


We never store finalized PSBTs in database. You can always try to finalize it to get the exact size and raise an error if you couldn't (which necessarily means the PSBT wasn't broadcast from our wallet):

liana/src/commands/mod.rs

Lines 761 to 773 in bcfab48

// First, try to finalize the spending transaction with the elements contained

// in the PSBT.

let mut spend_psbt = db_conn

.spend_tx(txid)

.ok_or(CommandError::UnknownSpend(*txid))?;

spend_psbt.finalize_mut(&self.secp).map_err(|e| {

CommandError::SpendFinalization(

e.into_iter()

.next()

.map(|e| e.to_string())

.unwrap_or_default(),

)

})?;

Or just using gettxspendingprevout would avoid the need for finalized PSBTs altogether.

darosior · 2023-12-06T08:25:26Z

src/commands/mod.rs

+        // Check replacement transaction's target feerate, if set, is high enough,
+        // and otherwise set it to the min feerate found above.
+        let feerate_vb = feerate_vb.unwrap_or(min_feerate_vb);
+        if feerate_vb < min_feerate_vb {
+            return Err(CommandError::RbfError(RbfErrorInfo::TooLowFeerate(
+                feerate_vb,
+            )));
+        }


I think we should only do that when cancelling. I don't see how not passing a feerate isn't a mistake otherwise. If you want to bump fees, bumping by 1s/vb isn't going to achieve much.

Conversely, i don't think there is any reason for setting the feerate when using a cancel.

darosior · 2023-12-06T08:28:28Z

src/commands/mod.rs

+                let address = bitcoin::Address::from_script(
+                    &txo.script_pubkey,
+                    self.config.bitcoin_config.network,
+                )
+                .expect("address already used in finalized transaction");


We don't sanity check PSBTs before storing them in DB so technically this might not hold.

src/commands/mod.rs

darosior · 2023-12-06T15:51:47Z

I've addressed my comments in separate commits for you to review and squash them in the appropriate ones.

575025d, cf10f13 and af4730b address commands: add rbfpsbt command #816 (comment) and commands: add rbfpsbt command #816 (comment)
de2f519 addresses commands: add rbfpsbt command #816 (comment)
c663bb1 addresses commands: add rbfpsbt command #816 (comment)
96f2a5d addresses commands: add rbfpsbt command #816 (comment)

I've also played with this a bit more. I think this is good to go if you agree with my changes.

jp1ac4 · 2023-12-06T16:23:04Z

src/commands/mod.rs

-            prev_coins
-        };
+        if !prev_psbt.unsigned_tx.is_explicitly_rbf() {
+            return Err(CommandError::RbfError(RbfErrorInfo::NotSignaling));


Should we rather check all the spending transactions in the mempool? Maybe using the bip125-replaceable field in getmempoolentry?

We can do that in a follow-up. Note however this is only checked for directly conflicting transactions.

I think the directly conflicting transactions should correspond to the mempool_spenders for the previous outpoints, but happy to come back to that in a follow-up.

`is_in_mempool` has been updated to use `mempool_entry`.

This is a more general version of `create_spend` in that it allows for a mixure of both mandatory and optional coin selection candidates and has a `min_fee` parameter. Another difference is that it takes destination addresses that have been checked for the network and amounts as `Amount`. `create_spend` has been updated to call `create_spend_internal`.

jp1ac4 · 2023-12-06T17:42:55Z

Thanks for your commits. I've now reviewed and squashed them as appropriate.

darosior · 2023-12-06T19:25:33Z

ACK 0ab00cd

0f69411 spend: a nicer interface for providing fee informations (Antoine Poinsot) 990b153 commands: don't query unconfirmed coins when creating recovery tx (Antoine Poinsot) c63a120 spend: don't use database's Coin type (Antoine Poinsot) 08ce0ad spend: update comment about create_spend behaviour (Antoine Poinsot) 0c395bb spend: document the create_spend function (Antoine Poinsot) f3113ba commands: remove redundant output value check (Antoine Poinsot) 5894e78 spend: move tx size calc helper back to command module (Antoine Poinsot) 6ddda61 spend: make coin selection helpers private (Antoine Poinsot) 33be1ff commands: make create_recovery use the create_spend helper (Antoine Poinsot) 0523f00 commands: update next deriv index for any spend output address (Antoine Poinsot) 5d50155 spend: avoid direct access to our Bitcoin backend (Antoine Poinsot) 7c23812 spend: don't access the database in the PSBT creation function (Antoine Poinsot) 22f97e1 spend: let caller update next derivation index (Antoine Poinsot) 9fdb75c commands: split up spend transaction creation into its own module (Antoine Poinsot) Pull request description: Based on top of #816, this introduces a new `spend` module with a helper to create a transaction spending coins from the wallet. It can be leveraged to create regular or recovery transactions, and also replacement for them. All the data structures used by the exposed spend creation function are contained with this module, in order to make it usable without a `lianad`-specific database and Bitcoin interface. This PR is structured in an incremental fashion. First we pull out the `create_spend_internal` method introduced in #816 into a standalone `spend` module, then we incrementally remove the cruft and the ties from the spend module to the other components. ACKs for top commit: darosior: self-ACK 0f69411 Tree-SHA512: a75afeb2c1f58e685c6b6e0d88c53e158ad850266261ef93b20065f6b02ad9e817cefcef4a89dc038e4db81549efc6d5393e4c59b4f7d86b69dc2168b9d818d3

jp1ac4 commented Nov 16, 2023

View reviewed changes

src/bitcoin/d/mod.rs Outdated Show resolved Hide resolved

src/commands/mod.rs Outdated Show resolved Hide resolved

jp1ac4 force-pushed the add-rbf-command branch 2 times, most recently from 859e6e0 to b3e143d Compare November 17, 2023 09:47

darosior reviewed Nov 17, 2023

View reviewed changes

src/bitcoin/d/mod.rs Outdated Show resolved Hide resolved

jp1ac4 force-pushed the add-rbf-command branch 2 times, most recently from c2b8f47 to add65fe Compare November 17, 2023 16:00

jp1ac4 commented Nov 17, 2023

View reviewed changes

jp1ac4 force-pushed the add-rbf-command branch from add65fe to 4a3e657 Compare November 17, 2023 20:49

darosior reviewed Nov 20, 2023

View reviewed changes

jp1ac4 force-pushed the add-rbf-command branch from 4a3e657 to fff63a3 Compare November 21, 2023 13:03

darosior reviewed Nov 21, 2023

View reviewed changes

tests/test_rpc.py Show resolved Hide resolved

gui/src/app/state/transactions.rs Outdated Show resolved Hide resolved

gui/src/daemon/model.rs Outdated Show resolved Hide resolved

jp1ac4 force-pushed the add-rbf-command branch 2 times, most recently from 2c29cd5 to 8ee4112 Compare November 23, 2023 18:19

darosior reviewed Nov 24, 2023

View reviewed changes

src/commands/mod.rs Outdated Show resolved Hide resolved

jp1ac4 force-pushed the add-rbf-command branch 5 times, most recently from 3e2d37e to 19a1b2d Compare November 27, 2023 15:34

jp1ac4 commented Nov 27, 2023

View reviewed changes

src/commands/utils.rs Show resolved Hide resolved

jp1ac4 added 2 commits November 28, 2023 13:55

func tests: run black

fdab722

func tests: move function to utils

68b2503

jp1ac4 force-pushed the add-rbf-command branch from 19a1b2d to ac5a00c Compare November 28, 2023 14:11

jp1ac4 changed the title ~~[WIP] commands: add rbfpsbt command~~ commands: add rbfpsbt command Nov 28, 2023

jp1ac4 marked this pull request as ready for review November 28, 2023 14:38

jp1ac4 commented Nov 28, 2023

View reviewed changes

src/commands/mod.rs Outdated Show resolved Hide resolved

jp1ac4 commented Nov 28, 2023

View reviewed changes

darosior self-requested a review November 29, 2023 12:55

darosior reviewed Nov 29, 2023

View reviewed changes

darosior reviewed Nov 30, 2023

View reviewed changes

darosior mentioned this pull request Nov 30, 2023

Standalone module for creating a spend transaction #842

Merged

jp1ac4 force-pushed the add-rbf-command branch from ac5a00c to 01d50c9 Compare December 4, 2023 23:58

jp1ac4 commented Dec 5, 2023

View reviewed changes

darosior reviewed Dec 6, 2023

View reviewed changes

jp1ac4 commented Dec 6, 2023

View reviewed changes

jp1ac4 added 4 commits December 6, 2023 17:35

bitcoin: add mempool_spenders to Bitcoin interface

714fd5e

`is_in_mempool` has been updated to use `mempool_entry`.

commands: add rbfpsbt command

5391bfe

gui: keep conflicting PSBTs as Pending until confirmation

0ab00cd

jp1ac4 force-pushed the add-rbf-command branch from 96f2a5d to 0ab00cd Compare December 6, 2023 17:37

darosior merged commit f4d22a9 into wizardsardine:master Dec 6, 2023
18 checks passed

jp1ac4 deleted the add-rbf-command branch December 6, 2023 23:44

This was referenced Dec 7, 2023

RBF follow-ups #853

Open

RBF for transactions broadcast from another wallet #854

Closed

		\| `is_cancel` \| bool \| Whether to "cancel" the transaction or simply bump the fee. \|
		\| `feerate` \| integer(optional) \| Target feerate for the RBF transaction (in sat/vb). \|

	// First, try to finalize the spending transaction with the elements contained
	// in the PSBT.
	let mut spend_psbt = db_conn
	.spend_tx(txid)
	.ok_or(CommandError::UnknownSpend(*txid))?;
	spend_psbt.finalize_mut(&self.secp).map_err(\|e\| {
	CommandError::SpendFinalization(
	e.into_iter()
	.next()
	.map(\|e\| e.to_string())
	.unwrap_or_default(),
	)
	})?;

commands: add rbfpsbt command #816

commands: add rbfpsbt command #816

Conversation

jp1ac4 commented Nov 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darosior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jp1ac4 commented Nov 21, 2023

darosior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darosior left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jp1ac4 commented Nov 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darosior commented Nov 30, 2023

darosior commented Nov 30, 2023

jp1ac4 commented Dec 4, 2023

jp1ac4 commented Dec 5, 2023

jp1ac4 commented Dec 5, 2023

darosior commented Dec 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darosior Dec 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darosior commented Dec 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jp1ac4 commented Dec 6, 2023

darosior commented Dec 6, 2023

commands: add `rbfpsbt` command #816

commands: add `rbfpsbt` command #816

darosior left a comment •

edited

Loading

darosior Dec 5, 2023 •

edited

Loading