Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Merge Windows into CMake matrix #7153

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

spacey-sooty
Copy link
Contributor

@spacey-sooty spacey-sooty commented Oct 3, 2024

There wasn't a reason to have this seperate.

Also remove WITH_JAVA=OFF flags which are unnecessary as WITH_JAVA defaults to OFF since #6975

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty spacey-sooty requested a review from a team as a code owner October 3, 2024 08:40

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Jade Turner <[email protected]>
review

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Jade Turner <[email protected]>
rzblue
rzblue previously approved these changes Oct 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@PeterJohnson PeterJohnson merged commit dced751 into wpilibsuite:main Oct 3, 2024
30 checks passed
@rzblue rzblue mentioned this pull request Oct 3, 2024
@spacey-sooty spacey-sooty deleted the merge-windows-ci branch October 4, 2024 01:23
Gold856 pushed a commit to Gold856/allwpilib that referenced this pull request Oct 10, 2024
Gold856 pushed a commit to Gold856/allwpilib that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants