-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-1047: Upgrade to Node 20 #1555
Conversation
6aa0ae3
to
a4afd56
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1555 +/- ##
========================================
Coverage 74.54% 74.54%
========================================
Files 421 421
Lines 14379 14379
========================================
Hits 10719 10719
Misses 3660 3660
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this was much less complicated than the migration to 18
Code Climate has analyzed commit 4bc2dd3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
Closes #1541
Changes proposed in this pull request
Checklist
Version 20 checklist:
rm -fr node_modules
.nvmrc
nvm install
nvm use
yarn install --dev
yarn prettier --write .
yarn lint
yarn test
./compile-build
docker-compose build --no-cache
docker-compose up
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version