Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-1047: Upgrade to Node 20 #1555

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Jan 19, 2024

Closes #1541

Changes proposed in this pull request

  • Upgrade to Node 20 (current LTS production version)
  • Update Docker to use Node 20

Checklist

Version 20 checklist:

  • rm -fr node_modules
  • Update .nvmrc
  • nvm install
  • nvm use
  • yarn install --dev
  • yarn prettier --write .
  • yarn lint
  • yarn test
  • ./compile-build
  • docker-compose build --no-cache
  • docker-compose up

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (93ff0e0) to head (4bc2dd3).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1555   +/-   ##
========================================
  Coverage    74.54%   74.54%           
========================================
  Files          421      421           
  Lines        14379    14379           
========================================
  Hits         10719    10719           
  Misses        3660     3660           
Flag Coverage Δ
javascript 59.64% <ø> (ø)
pull_request 74.54% <ø> (?)
push 74.54% <ø> (ø)
ruby 91.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sdjmchattie sdjmchattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this was much less complicated than the migration to 18

Copy link

codeclimate bot commented Aug 19, 2024

Code Climate has analyzed commit 4bc2dd3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@StephenHulme StephenHulme merged commit e6dbcf0 into develop Aug 19, 2024
20 checks passed
@StephenHulme StephenHulme deleted the dpl-1047-upgrade-to-node-20 branch August 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-1047 Upgrade from Node 14
3 participants